[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] gitlab: add special rule for the hexagon container
From: |
Alex Bennée |
Subject: |
Re: [RFC PATCH] gitlab: add special rule for the hexagon container |
Date: |
Mon, 24 May 2021 16:04:37 +0100 |
User-agent: |
mu4e 1.5.13; emacs 28.0.50 |
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Mon, May 24, 2021 at 07:35:59AM -0700, Richard Henderson wrote:
>> On 5/20/21 8:19 AM, Alex Bennée wrote:
>> > The hexagon container is always manually built but of course not
>> > everyone will be building it themselves and pushing to their
>> > registries. We still need to create a "local" registry copy for the
>> > actual gitlab tests to run. We don't build it in this case, just pull
>> > it across from the upstream registry. We disable this rule from
>> > running on the qemu-project itself so it doesn't accidentally wipe out
>> > our master copy.
>> >
>> > Fixes: 910c40ee94 ("gitlab: add build-user-hexagon test")
>> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> > Cc: Cornelia Huck <cohuck@redhat.com>
>> > ---
>>
>> I get
>>
>> Found errors in your .gitlab-ci.yml:
>> jobs:build-user-hexagon:needs config uses invalid types: bridge
>
> Bizarre message, but the problem looks like this:
>
>
>> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> > index f718b61fa7..a04cca9db0 100644
>> > --- a/.gitlab-ci.yml
>> > +++ b/.gitlab-ci.yml
>> > @@ -421,6 +421,8 @@ build-user-static:
>> > # declared. The image is manually uploaded.
>> > build-user-hexagon:
>> > extends: .native_build_job_template
>> > + needs:
>> > + hob: hexagon-cross-container
>
> Indent and syntax is wrong - should be
>
> needs:
> - job: hexagon-cross-container
>
> with indent at same level as 'extends'
This is why v2 was posted fairly quickly :-/
Also in the rolled up series I posted on Thursday:
Subject: [PATCH v1 0/8] various misc fixes (gitlab, gdbstub, plugins)
Date: Thu, 20 May 2021 18:42:55 +0100
Message-Id: <20210520174303.12310-1-alex.bennee@linaro.org>
>
>> > variables:
>> > IMAGE: debian-hexagon-cross
>> > TARGETS: hexagon-linux-user
>> >
>>
>>
>
> Regards,
> Daniel
--
Alex Bennée