qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when t


From: Peter Maydell
Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled
Date: Tue, 25 May 2021 18:15:40 +0100

On Tue, 25 May 2021 at 17:28, Swetha Joshi <swethajoshi139@gmail.com> wrote:
>
> Hey Peter, Phil,
>
> Yeah like Peter mentioned, when KVM is enabled and we don't want VIRT 
> enabled, there are a couple of routines that are being called from virt.h and 
> ghes.h, which is resulting in errors. I came up with this simple fix but if 
> you think there is a better solution to it I'll let you/ other developers who 
> own it decide and fix it because I don't have much experience or visibility 
> into what happens internally, my knowledge is restricted to just using the 
> configs.

Well, QEMU builds fine for me as-is, because the default config
always enables the virt board. Do you have repro instructions for
reproducing the build failure ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]