[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH_V3] Adding ifdefs to call the respective routines only when t
From: |
Peter Maydell |
Subject: |
Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled |
Date: |
Tue, 25 May 2021 18:15:40 +0100 |
On Tue, 25 May 2021 at 17:28, Swetha Joshi <swethajoshi139@gmail.com> wrote:
>
> Hey Peter, Phil,
>
> Yeah like Peter mentioned, when KVM is enabled and we don't want VIRT
> enabled, there are a couple of routines that are being called from virt.h and
> ghes.h, which is resulting in errors. I came up with this simple fix but if
> you think there is a better solution to it I'll let you/ other developers who
> own it decide and fix it because I don't have much experience or visibility
> into what happens internally, my knowledge is restricted to just using the
> configs.
Well, QEMU builds fine for me as-is, because the default config
always enables the virt board. Do you have repro instructions for
reproducing the build failure ?
thanks
-- PMM
- [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Swetha Joshi, 2021/05/24
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Richard Henderson, 2021/05/24
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Philippe Mathieu-Daudé, 2021/05/25
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Peter Maydell, 2021/05/25
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Swetha Joshi, 2021/05/25
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled,
Peter Maydell <=
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Swetha Joshi, 2021/05/26
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Peter Maydell, 2021/05/26
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Dongjiu Geng, 2021/05/28
- Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled, Swetha Joshi, 2021/05/28