Re: [PATCH v6 18/25] python/qemu: add isort to pipenv

[John Snow]

On 5/25/21 11:56 AM, Cleber Rosa wrote:
> On Wed, May 12, 2021 at 07:12:34PM -0400, John Snow wrote:
> > isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret
> > certain "from ..." clauses that are not related to imports.
> >
> > isort < 5.1.1 has a bug where it does not handle comments near import
> > statements correctly.
> >
> > Require 5.1.2 or greater.
> >
> > isort can be run with 'isort -c qemu' from the python root.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   python/Pipfile      | 1 +
> >   python/Pipfile.lock | 4 ++--
> >   2 files changed, 3 insertions(+), 2 deletions(-)
>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>

Thanks. I have also updated the commit message a little bit:

isort can be run (in "check" mode) with 'isort -c qemu' from the python
root. isort can also be used to fix/rewrite import order automatically
by using 'isort qemu'.

--js