Re: [RFC PATCH 04/15] accel: Only use TCG when building user-mode emulation

[Richard Henderson]

On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   accel/meson.build | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)

I think the description should be clearer, since the restriction being applied 
is for system emulation.  How about

meson: Only build hw virtualization with system emulation

> diff --git a/accel/meson.build b/accel/meson.build
> index b44ba30c864..0e296911aea 100644
> --- a/accel/meson.build
> +++ b/accel/meson.build
> @@ -2,11 +2,13 @@
>   softmmu_ss.add(files('accel-softmmu.c'))
>   user_ss.add(files('accel-user.c'))
>   
> -subdir('qtest')
> -subdir('kvm')
>   subdir('tcg')
> -subdir('xen')
> -subdir('stubs')
> +if have_system
> +  subdir('kvm')
> +  subdir('qtest')
> +  subdir('stubs')
> +  subdir('xen')
> +endif

The patch itself looks fine.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~