[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 14/15] softmmu/cpus: Extract QMP command handlers to cpus
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH 14/15] softmmu/cpus: Extract QMP command handlers to cpus-qmp.c |
Date: |
Wed, 26 May 2021 23:35:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 5/26/21 9:10 PM, Richard Henderson wrote:
> On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote:
>> qmp_memsave() and qmp_pmemsave() call cpu_memory_rw_debug()
>> and cpu_physical_memory_read(), which are target specific
>> prototypes.
>
> Is there any reason they should be?
They use target_ulong. Should they use hwaddr instead?
> In the short-term though,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
>
[RFC PATCH 15/15] softmmu: Build target-agnostic objects once, Philippe Mathieu-Daudé, 2021/05/17