[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] hw/arm/Kconfig: Add missing dependency IMX_USBPHY -> FSL
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 3/3] hw/arm/Kconfig: Add missing dependency IMX_USBPHY -> FSL_IMX6UL |
|
Date: |
Thu, 27 May 2021 10:29:28 +0100 |
On Wed, 19 May 2021 at 21:10, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX
> USB Phy support") and had the FSL_IMX6 machine select it, however
> this machine did not use the IMX_USBPHY until commit 49cd55789bb
> ("hw/arm/fsl-imx6: Wire up USB controllers"). Commit 17372bd812d
> ("hw/arm/fsl-imx6ul: Wire up USB controllers") added the similar
> dependency but forgot to select the Kconfig symbol. Do it now to
> solve when building using --without-default-devices:
>
> $ qemu-system-arm -M mcimx6ul-evk
> qemu-system-arm: missing object type 'imx.usbphy'
> Aborted (core dumped)
>
> Fixes: 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/arm/Kconfig | 1 +
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM