[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write |
Date: |
Thu, 27 May 2021 09:20:04 +0100 |
On Tue, May 18, 2021 at 12:07:51PM +0200, Emanuele Giuseppe Esposito wrote:
> } else {
> /*
> * We enable copy-range, but keep small copy_size, until first
> * successful copy_range (look at block_copy_do_copy).
> */
Is this comment still correct? It appears that this branch of the if
statement does not always enable copy-range (the !use_copy_range case).
> - s->use_copy_range = use_copy_range;
> - s->copy_size = MAX(s->cluster_size, BLOCK_COPY_MAX_BUFFER);
> + s->method = use_copy_range ? COPY_RANGE_SMALL : COPY_READ_WRITE;
signature.asc
Description: PGP signature
Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write,
Stefan Hajnoczi <=
[PATCH v2 2/7] block-copy: improve documentation of BlockCopyTask and BlockCopyState types and functions, Emanuele Giuseppe Esposito, 2021/05/18
[PATCH v2 3/7] block-copy: move progress_set_remaining in block_copy_task_end, Emanuele Giuseppe Esposito, 2021/05/18
[PATCH v2 5/7] block-copy: add QemuMutex lock for BlockCopyCallState list, Emanuele Giuseppe Esposito, 2021/05/18