[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 06/31] python/machine: disable warning for Popen in _launch()
From: |
John Snow |
Subject: |
[PATCH v8 06/31] python/machine: disable warning for Popen in _launch() |
Date: |
Thu, 27 May 2021 17:16:50 -0400 |
We handle this resource rather meticulously in
shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in
_do_shutdown().
Quiet this pylint warning here.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210517184808.3562549-7-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index c66bc6a9c69..5d72c4ca369 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -405,6 +405,9 @@ def _launch(self) -> None:
self._args)
)
LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args))
+
+ # Cleaning up of this subprocess is guaranteed by _do_shutdown.
+ # pylint: disable=consider-using-with
self._popen = subprocess.Popen(self._qemu_full_args,
stdin=subprocess.DEVNULL,
stdout=self._qemu_log_file,
--
2.31.1
- [PATCH v8 00/31] python: create installable package, John Snow, 2021/05/27
- [PATCH v8 02/31] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull), John Snow, 2021/05/27
- [PATCH v8 01/31] python/console_socket: avoid one-letter variable, John Snow, 2021/05/27
- [PATCH v8 03/31] python/machine: use subprocess.run instead of subprocess.Popen, John Snow, 2021/05/27
- [PATCH v8 04/31] python/console_socket: Add a pylint ignore, John Snow, 2021/05/27
- [PATCH v8 05/31] python/machine: Disable pylint warning for open() in _pre_launch, John Snow, 2021/05/27
- [PATCH v8 06/31] python/machine: disable warning for Popen in _launch(),
John Snow <=
- [PATCH v8 07/31] python/machine: Trim line length to below 80 chars, John Snow, 2021/05/27
- [PATCH v8 08/31] iotests/297: add --namespace-packages to mypy arguments, John Snow, 2021/05/27
- [PATCH v8 09/31] python: create qemu packages, John Snow, 2021/05/27
- [PATCH v8 10/31] python: add qemu package installer, John Snow, 2021/05/27
- [PATCH v8 11/31] python: add VERSION file, John Snow, 2021/05/27
- [PATCH v8 13/31] python: add MANIFEST.in, John Snow, 2021/05/27
- [PATCH v8 12/31] python: add directory structure README.rst files, John Snow, 2021/05/27
- [PATCH v8 14/31] python: Add pipenv support, John Snow, 2021/05/27
- [PATCH v8 15/31] python: add pylint import exceptions, John Snow, 2021/05/27
- [PATCH v8 16/31] python: move pylintrc into setup.cfg, John Snow, 2021/05/27