|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc() |
Date: | Mon, 31 May 2021 19:22:00 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 |
31.05.2021 18:50, Kevin Wolf wrote:
Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben:All existing parent types (block nodes, block devices, jobs) has the realization. So, drop unreachable code. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>Your fixes the other days showed that vvfat has a BdrvChildClass, too. This instance doesn't define .get_parent_desc(), so the code that this patch removes is potentially still reachable.
Right. Will fix it and add an assertion to bdrv_attach_child_common() -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |