[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr |
|
Date: |
Tue, 1 Jun 2021 05:29:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 5/27/21 6:14 AM, Richard Henderson wrote:
> The comment about not signaling all underflow cases is
> almost certainly incorrect. It has been there since the
> initial commit of the file.
>
> There is a bit of code below that sets underflow with
> float_flag_oflush_denormal, which is probably the fix
> for whatever the original case may have been.
>
> Cc: Yongbok Kim <yongbok.kim@mips.com>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/mips/tcg/msa_helper.c | 32 ++++++++++----------------------
> 1 file changed, 10 insertions(+), 22 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 06/11] target/rx: Handle the FPSW.DN bit in helper_set_fpsw, (continued)
- [PATCH 06/11] target/rx: Handle the FPSW.DN bit in helper_set_fpsw, Richard Henderson, 2021/05/27
- [PATCH 08/11] target/rx: Fix setting of FPSW.CE, Richard Henderson, 2021/05/27
- [PATCH 09/11] target/mips: Drop inline markers from msa_helper.c, Richard Henderson, 2021/05/27
- [PATCH 10/11] target/mips: Do not check MSACSR_FS_MASK in update_msacsr, Richard Henderson, 2021/05/27
- [PATCH 04/11] softfloat: Introduce float_flag_result_denormal, Richard Henderson, 2021/05/27
- [PATCH 05/11] target/i386: Use float_flag_inorm_denormal, Richard Henderson, 2021/05/27
- [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr, Richard Henderson, 2021/05/27
- Re: [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr,
Philippe Mathieu-Daudé <=