Re: [PATCH v3 13/33] block/nbd: introduce nbd_client_connection_release()

[Vladimir Sementsov-Ogievskiy]

03.06.2021 00:27, Eric Blake wrote:
> On Fri, Apr 16, 2021 at 11:08:51AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   block/nbd.c | 43 ++++++++++++++++++++++++++-----------------
> >   1 file changed, 26 insertions(+), 17 deletions(-)
>
> Commit message said what, but not why.  Presumably this is one more
> bit of refactoring to make the upcoming file split in a later patch
> easier.  But patch 12/33 said it was the last step before a new file,
> and this patch isn't yet at a new file.  Missing some continuity in
> your commit messages?

Seems like one more small additional step after last step )

> > diff --git a/block/nbd.c b/block/nbd.c
> > index 21a4039359..8531d019b2 100644
> > --- a/block/nbd.c
> > +++ b/block/nbd.c
> > @@ -118,7 +118,7 @@ typedef struct BDRVNBDState {
> >       NBDClientConnection *conn;
> >   } BDRVNBDState;
> >   
> > -static void nbd_free_connect_thread(NBDClientConnection *conn);
> > +static void nbd_client_connection_release(NBDClientConnection *conn);
>
> Is it necessary for a forward declaration, or can you just implement
> the new function prior to its users?

Hmm, seems it could be easily moved.

> At any rate, the refactoring looks sane.


--
Best regards,
Vladimir