qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace ev


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace events
Date: Mon, 7 Jun 2021 10:28:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 6/7/21 9:33 AM, Laurent Vivier wrote:
> Le 02/06/2021 à 12:49, Philippe Mathieu-Daudé a écrit :
>> Cc'ing qemu-trivial@
>>
>> On 3/18/21 4:39 PM, Philippe Mathieu-Daudé wrote:
>>> ping?
>>>
>>> On 3/7/21 8:48 AM, Philippe Mathieu-Daudé wrote:
>>>> MemoryRegion names is cached on first call to memory_region_name(),
> 
> It is cached on first call but now that it is used in the trace function, 
> does it mean it will be
> always allocated in memory?

Yes, this is how memory_region_name() works:

const char *memory_region_name(const MemoryRegion *mr)
{
    if (!mr->name) {
        ((MemoryRegion *)mr)->name =
            g_strdup(object_get_canonical_path_component(OBJECT(mr)));
    }
    return mr->name;
}


> 
> Thanks,
> Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]