[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 5/8] gitlab: work harder to avoid false positives in checkpatc
From: |
Daniel P . Berrangé |
Subject: |
Re: [PULL 5/8] gitlab: work harder to avoid false positives in checkpatch |
Date: |
Mon, 7 Jun 2021 15:50:47 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Mon, Jun 07, 2021 at 03:33:00PM +0100, Alex Bennée wrote:
> This copies the behaviour of patchew's configuration to make the diff
> algorithm generate a minimal diff.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Message-Id: <20210602153247.27651-1-alex.bennee@linaro.org>
>
> diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
> index 8e30872164..7e685c6a65 100644
> --- a/.gitlab-ci.d/static_checks.yml
> +++ b/.gitlab-ci.d/static_checks.yml
> @@ -3,7 +3,11 @@ check-patch:
> image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
> needs:
> job: amd64-centos8-container
> - script: .gitlab-ci.d/check-patch.py
> + script:
> + - git config --local diff.renamelimit 0
> + - git config --local diff.renames True
> + - git config --local diff.algorithm histogram
> + - .gitlab-ci.d/check-patch.py
No objection to merging this patch as is, but I wonder if we ought to
make scripts/checkpatch.pl set these options explicitly when it runs
git, eg
git -c diff.renamelimit=0 -c diff.renames=True ...etc show
so that everyone who runs checkpatch.pl benefits from the improvement.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PULL 0/8] testing and misc updates, Alex Bennée, 2021/06/07
- [PULL 1/8] tests/tcg: add a multiarch signals test to stress test signal delivery, Alex Bennée, 2021/06/07
- [PULL 2/8] meson.build: fix cosmetics of compiler display, Alex Bennée, 2021/06/07
- [PULL 4/8] tests/acceptance: tag various arm tests as TCG only, Alex Bennée, 2021/06/07
- [PULL 3/8] tests/tcg/configure.sh: tweak quoting of target_compiler, Alex Bennée, 2021/06/07
- [PULL 5/8] gitlab: work harder to avoid false positives in checkpatch, Alex Bennée, 2021/06/07
- Re: [PULL 5/8] gitlab: work harder to avoid false positives in checkpatch,
Daniel P . Berrangé <=
- [PULL 6/8] gitlab-ci: Split gprof-gcov job, Alex Bennée, 2021/06/07
- [PULL 8/8] scripts/checkpatch.pl: process .c.inc and .h.inc files as C source, Alex Bennée, 2021/06/07
- [PULL 7/8] tests/vm: expose --source-path to scripts to find extra files, Alex Bennée, 2021/06/07
- Re: [PULL 0/8] testing and misc updates, Peter Maydell, 2021/06/07