Re: [PATCH] tcg: Introduce tcg_remove_ops_after

[Richard Henderson]

On 6/7/21 6:51 AM, Peter Maydell wrote:
> > +void tcg_remove_ops_after(TCGOp *op);
>
> A doc comment would be nice.

Fair enough.

> This looks OK as far as TCG proper goes, but is it going to confuse
> the TCG plugin infrastructure if a frontend generates a bunch of
> TCG IR and then winds back the insn stream and generates something
> else instead ? I see some calls from tcg/ into plugin related
> functions, so I'm not sure...

Mm.  Didn't think about that Friday.  But looking now, if you wind back to 
dc->insn_start, everything will be fine.

The plugin stuff will put stuff in the stream, and then go back and 
post-process it.  But it does not record anything on the side, so if the stuff 
is no longer in the stream all's well.


r~