[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initiali
From: |
Eric Blake |
Subject: |
Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls |
Date: |
Mon, 7 Jun 2021 11:03:50 -0500 |
User-agent: |
NeoMutt/20210205 |
On Fri, May 14, 2021 at 11:14:23PM +0200, Paolo Bonzini wrote:
> On 14/05/21 15:13, Mirela Grujic wrote:
> > However, if you believe it should rather be just renamed I can do so.
>
> I am just not sure it's such an advantage to replace phase_check with
> separate functions. The rename is a constraint of QAPI, so we have to live
> with the long names.
You can also use 'prefix':'...' as part of the QAPI 'enum' declaration
to pick a shorter name for the C enum (see for example BlkdebugEvent
in block-core.json).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls,
Eric Blake <=