Re: [PATCH v3 23/26] s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)

[David Hildenbrand]

On 07.06.21 18:20, Richard Henderson wrote:
> On 6/7/21 4:03 AM, David Hildenbrand wrote:
> > +static S390MinMaxRes vfmin_res(uint16_t dcmask_a, uint16_t dcmask_b,
> > +                               S390MinMaxType type, float_status *s)
> > +{
> > +    const bool neg_a = dcmask_a & DCMASK_NEGATIVE;
>
> Minor nits:
> Only used in the zero block.
>
> > +    const bool nan_a = dcmask_a & DCMASK_NAN;
> > +    const bool nan_b = dcmask_b & DCMASK_NAN;
>
> Only used in the nan block.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> r~

Indeed, will move these into the blocks -- thanks!

--
Thanks,

David / dhildenb