[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/42] scripts/qmp-shell: use @classmethod where appropriate
From: |
John Snow |
Subject: |
[PATCH 07/42] scripts/qmp-shell: use @classmethod where appropriate |
Date: |
Mon, 7 Jun 2021 16:06:14 -0400 |
Methods with no self-use should belong to the class.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qmp/qmp-shell | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index ae3f04534a..f354549bf2 100755
--- a/scripts/qmp/qmp-shell
+++ b/scripts/qmp/qmp-shell
@@ -97,7 +97,8 @@ class FuzzyJSON(ast.NodeTransformer):
'''This extension of ast.NodeTransformer filters literal "true/false/null"
values in an AST and replaces them by proper "True/False/None" values that
Python can properly evaluate.'''
- def visit_Name(self, node):
+ @classmethod
+ def visit_Name(cls, node):
if node.id == 'true':
node.id = 'True'
if node.id == 'false':
@@ -152,7 +153,8 @@ class QMPShell(qmp.QEMUMonitorProtocol):
except Exception as e:
print("Failed to save history file '%s'; %s" % (self._histfile, e))
- def __parse_value(self, val):
+ @classmethod
+ def __parse_value(cls, val):
try:
return int(val)
except ValueError:
--
2.31.1
- [PATCH 00/42] python: move qmp-shell into qemu.qmp package, John Snow, 2021/06/07
- [PATCH 02/42] scripts/qmp-shell: Apply flake8 rules, John Snow, 2021/06/07
- [PATCH 12/42] scripts/qmp-shell: make QMPCompleter returns explicit, John Snow, 2021/06/07
- [PATCH 05/42] scripts/qmp-shell: fix connect method signature, John Snow, 2021/06/07
- [PATCH 01/42] scripts/qmp-shell: apply isort rules, John Snow, 2021/06/07
- [PATCH 04/42] scripts/qmp-shell: fix exception handling, John Snow, 2021/06/07
- [PATCH 06/42] scripts/qmp-shell: remove shadowed variable from _print(), John Snow, 2021/06/07
- [PATCH 07/42] scripts/qmp-shell: use @classmethod where appropriate,
John Snow <=
- [PATCH 03/42] scripts/qmp-shell: fix show_banner signature, John Snow, 2021/06/07
- [PATCH 21/42] scripts/qmp-shell: remove prompt argument from read_exec_command, John Snow, 2021/06/07
- [PATCH 08/42] scripts/qmp-shell: Use python3-style super(), John Snow, 2021/06/07
- [PATCH 11/42] scripts/qmp-shell: ignore visit_Name name, John Snow, 2021/06/07
- [PATCH 09/42] scripts/qmp-shell: declare verbose in __init__, John Snow, 2021/06/07
- [PATCH 14/42] scripts/qmp-shell: fix shell history exception handling, John Snow, 2021/06/07
- [PATCH 20/42] scripts/qmp-shell: move get_prompt() to prompt property, John Snow, 2021/06/07
- [PATCH 10/42] scripts/qmp-shell: use triple-double-quote docstring style, John Snow, 2021/06/07
- [PATCH 18/42] scripts/qmp-shell: Add pretty attribute to HMP shell, John Snow, 2021/06/07
- [PATCH 15/42] scripts/qmp-shell: remove if-raise-else patterns, John Snow, 2021/06/07