qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 25/29] softfloat: Convert float32_exp2 to FloatParts


From: Richard Henderson
Subject: Re: [PULL 25/29] softfloat: Convert float32_exp2 to FloatParts
Date: Mon, 7 Jun 2021 15:28:29 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/7/21 2:07 PM, Peter Maydell wrote:
+    FloatParts64 xp, xnp, tp, rp;

Coverity points out that we declare tp here without initializing it...
...
+    float64_unpack_canonical(&xnp, float64_ln2, status);
+    xp = *parts_mul(&xp, &tp, status);

...and then here we pass &tp to parts_mul() which looks at
its various fields. Missing initializer of some sort ?

Typo in the unpack; should have been tp.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]