[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/7] Optimize the function of filter_send
From: |
Zhang Chen |
Subject: |
[PATCH 3/7] Optimize the function of filter_send |
Date: |
Tue, 8 Jun 2021 16:23:27 +0800 |
From: "Rao, Lei" <lei.rao@intel.com>
The iov_size has been calculated in filter_send(). we can directly
return the size.In this way, this is no need to repeat calculations
in filter_redirector_receive_iov();
Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Tested-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
net/filter-mirror.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/filter-mirror.c b/net/filter-mirror.c
index f8e65007c0..f20240cc9f 100644
--- a/net/filter-mirror.c
+++ b/net/filter-mirror.c
@@ -88,7 +88,7 @@ static int filter_send(MirrorState *s,
goto err;
}
- return 0;
+ return size;
err:
return ret < 0 ? ret : -EIO;
@@ -159,7 +159,7 @@ static ssize_t filter_mirror_receive_iov(NetFilterState *nf,
int ret;
ret = filter_send(s, iov, iovcnt);
- if (ret) {
+ if (ret < 0) {
error_report("filter mirror send failed(%s)", strerror(-ret));
}
@@ -182,10 +182,10 @@ static ssize_t
filter_redirector_receive_iov(NetFilterState *nf,
if (qemu_chr_fe_backend_connected(&s->chr_out)) {
ret = filter_send(s, iov, iovcnt);
- if (ret) {
+ if (ret < 0) {
error_report("filter redirector send failed(%s)", strerror(-ret));
}
- return iov_size(iov, iovcnt);
+ return ret;
} else {
return 0;
}
--
2.25.1
- [PATCH 0/7] COLO proxy patch, Zhang Chen, 2021/06/08
- [PATCH 4/7] Remove migrate_set_block_enabled in checkpoint, Zhang Chen, 2021/06/08
- [PATCH 3/7] Optimize the function of filter_send,
Zhang Chen <=
- [PATCH 1/7] Remove some duplicate trace code., Zhang Chen, 2021/06/08
- [PATCH 2/7] Fix the qemu crash when guest shutdown during checkpoint, Zhang Chen, 2021/06/08
- [PATCH 5/7] Add a function named packet_new_nocopy for COLO., Zhang Chen, 2021/06/08
- [PATCH 6/7] Add the function of colo_compare_cleanup, Zhang Chen, 2021/06/08
- [PATCH 7/7] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info(), Zhang Chen, 2021/06/08