Re: [PATCH v4 1/9] qapi: replace List[str] by QAPISchemaIfCond

[Marc-André Lureau]

Hi

On Mon, Jun 7, 2021 at 6:19 PM Eric Blake <eblake@redhat.com> wrote:

On Mon, May 17, 2021 at 08:30:32PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Wrap the 'if' condition in a higher-level object. Not only this allows
> more type safety but also further refactoring without too much churn.

Grammar suggestion:

Not only does this provide more type safety, but it also enables
further refactoring without too much churn.

done, thanks

>
> The following patches will change the syntax of the schema 'if'
> conditions to be predicate expressions, and will generate code for
> different target languages (C, and Rust in another series).
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Tested-by: John Snow <jsnow@redhat.com>
> ---

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--

Marc-André Lureau