qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 16/28] tcg: Replace region.end with region.total_size


From: Richard Henderson
Subject: Re: [PATCH v3 16/28] tcg: Replace region.end with region.total_size
Date: Tue, 8 Jun 2021 09:12:50 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/8/21 9:03 AM, Alex Bennée wrote:
@@ -279,7 +279,7 @@ static void tcg_region_bounds(size_t curr_region, void 
**pstart, void **pend)
          start = region.start;
      }
      if (curr_region == region.n - 1) {
-        end = region.end;
+        end = region.start_aligned + region.total_size;

So why isn't this end = start_aligned + (n * stride)? do we not line up
for the last region?

Correct. There's some commentary to that effect in tcg_region_init, but I guess it could stand to be copied here.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]