[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add Connor Kuehl as reviewer for AMD SEV
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] Add Connor Kuehl as reviewer for AMD SEV |
Date: |
Tue, 8 Jun 2021 20:34:13 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
* Connor Kuehl (ckuehl@redhat.com) wrote:
> It may not be appropriate for me to take over as a maintainer at this time,
> but I would consider myself familiar with AMD SEV and what this code is
> meant to be doing as part of a VMM for launching SEV-protected guests.
>
> To that end, I would be happy to volunteer as a reviewer for SEV-related
> changes so that I am CC'd on them and can help share the review burden with
> whoever does maintain this code.
>
> Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Ooh yes please, we could do with someone to be a reviewer;
> ---
> Note: because there's no maintainer entry, when running
> ./scripts/get_maintainers.pl on target/i386/sev.c, my name and the qemu
> mailing list is the only thing that shows up... it doesn't even show
> previous committers (as it would before applying this patch). Which is
> probably not great considering I do not make pull requests to QEMU.
>
> Is the way forward to get someone to sign up as a maintainer before
> applying a patch like this?
If you wanted to do a submaintainer for it and send it to one of the x86
maintainers rather than having to do full pulls?
Dave
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7d9cd29042..3eb7ce8fc6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2938,6 +2938,10 @@ F: hw/core/clock-vmstate.c
> F: hw/core/qdev-clock.c
> F: docs/devel/clocks.rst
>
> +AMD Secure Encrypted Virtualization
> +R: Connor Kuehl <ckuehl@redhat.com>
> +F: target/i386/sev.c
> +
> Usermode Emulation
> ------------------
> Overall usermode emulation
> --
> 2.31.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK