[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vnc: avoid deprecation warnings for SASL on OS X
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] vnc: avoid deprecation warnings for SASL on OS X |
|
Date: |
Wed, 9 Jun 2021 13:24:59 +0100 |
|
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Fri, Jun 04, 2021 at 02:09:15PM +0200, Paolo Bonzini wrote:
> Apple has deprecated sasl.h functions in OS X 10.11. Therefore,
> all files that use SASL API need to disable -Wdeprecated-declarations.
> Remove the only use that is outside vnc-auth-sasl.c and add the
> relevant #pragma GCC diagnostic there.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> ui/vnc-auth-sasl.c | 20 ++++++++++++++++++++
> ui/vnc-auth-sasl.h | 1 +
> ui/vnc.c | 10 ++--------
> 3 files changed, 23 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This matches what I did in libvirt a while ago to keep it quiet on macOS
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|