[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/9] migration/socket: Close the listener at the end
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 6/9] migration/socket: Close the listener at the end |
Date: |
Wed, 9 Jun 2021 15:45:09 +0100 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Delay closing the listener until the cleanup hook at the end; mptcp
needs the listener to stay open while the other paths come in.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210421112834.107651-5-dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/multifd.c | 5 +++++
migration/socket.c | 24 ++++++++++++++++++------
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 2e8f001bc0..ab41590e71 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -1166,6 +1166,11 @@ bool multifd_recv_all_channels_created(void)
return true;
}
+ if (!multifd_recv_state) {
+ /* Called before any connections created */
+ return false;
+ }
+
return thread_count == qatomic_read(&multifd_recv_state->count);
}
diff --git a/migration/socket.c b/migration/socket.c
index 6016642e04..05705a32d8 100644
--- a/migration/socket.c
+++ b/migration/socket.c
@@ -126,22 +126,31 @@ static void
socket_accept_incoming_migration(QIONetListener *listener,
{
trace_migration_socket_incoming_accepted();
- qio_channel_set_name(QIO_CHANNEL(cioc), "migration-socket-incoming");
- migration_channel_process_incoming(QIO_CHANNEL(cioc));
-
if (migration_has_all_channels()) {
- /* Close listening socket as its no longer needed */
- qio_net_listener_disconnect(listener);
- object_unref(OBJECT(listener));
+ error_report("%s: Extra incoming migration connection; ignoring",
+ __func__);
+ return;
}
+
+ qio_channel_set_name(QIO_CHANNEL(cioc), "migration-socket-incoming");
+ migration_channel_process_incoming(QIO_CHANNEL(cioc));
}
+static void
+socket_incoming_migration_end(void *opaque)
+{
+ QIONetListener *listener = opaque;
+
+ qio_net_listener_disconnect(listener);
+ object_unref(OBJECT(listener));
+}
static void
socket_start_incoming_migration_internal(SocketAddress *saddr,
Error **errp)
{
QIONetListener *listener = qio_net_listener_new();
+ MigrationIncomingState *mis = migration_incoming_get_current();
size_t i;
int num = 1;
@@ -156,6 +165,9 @@ socket_start_incoming_migration_internal(SocketAddress
*saddr,
return;
}
+ mis->transport_data = listener;
+ mis->transport_cleanup = socket_incoming_migration_end;
+
qio_net_listener_set_client_func_full(listener,
socket_accept_incoming_migration,
NULL, NULL,
--
2.31.1
- [PULL 0/9] migration queue, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 1/9] yank: Unregister function when using TLS migration, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 2/9] migration/rdma: Fix cm event use after free, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 3/9] channel-socket: Only set CLOEXEC if we have space for fds, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 4/9] io/net-listener: Call the notifier during finalize, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 6/9] migration/socket: Close the listener at the end,
Dr. David Alan Gilbert (git) <=
- [PULL 7/9] sockets: Support multipath TCP, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 5/9] migration: Add cleanup hook for inwards migration, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 9/9] hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds, Dr. David Alan Gilbert (git), 2021/06/09
- [PULL 8/9] migration/dirtyrate: make sample page count configurable, Dr. David Alan Gilbert (git), 2021/06/09
- Re: [PULL 0/9] migration queue, Peter Maydell, 2021/06/09
- Re: [PULL 0/9] migration queue, no-reply, 2021/06/14