[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/9] virtiofsd: Allow using file handles instead of O_PATH FDs
From: |
Max Reitz |
Subject: |
[PATCH v2 0/9] virtiofsd: Allow using file handles instead of O_PATH FDs |
Date: |
Wed, 9 Jun 2021 17:55:42 +0200 |
Hi,
v1 cover letter for an overview:
https://listman.redhat.com/archives/virtio-fs/2021-June/msg00033.html
In v2, I (tried to) fix the bug Dave found, which is that
get_file_handle() indiscriminately opened the given dirfd/name
combination to get an O_RDONLY fd without checking whether we’re
actually allowed to open dirfd/name; namely, we don’t allow ourselves to
open files that aren’t regular files or directories.
So that openat(.., O_RDONLY) is changed to an openat(..., O_PATH), and
then check the file type with the statx() we’re doing anyway. If the
file is OK to open, we reopen it O_RDONLY with the help of
/proc/self/fd, like we always do.
(This only affects patch 8.)
git-backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/9:[----] [--] 'virtiofsd: Add TempFd structure'
002/9:[----] [--] 'virtiofsd: Use lo_inode_open() instead of openat()'
003/9:[----] [--] 'virtiofsd: Add lo_inode_fd() helper'
004/9:[----] [--] 'virtiofsd: Let lo_fd() return a TempFd'
005/9:[----] [--] 'virtiofsd: Let lo_inode_open() return a TempFd'
006/9:[----] [--] 'virtiofsd: Add lo_inode.fhandle'
007/9:[----] [--] 'virtiofsd: Add inodes_by_handle hash table'
008/9:[0045] [FC] 'virtiofsd: Optionally fill lo_inode.fhandle'
009/9:[----] [--] 'virtiofsd: Add lazy lo_do_find()'
Max Reitz (9):
virtiofsd: Add TempFd structure
virtiofsd: Use lo_inode_open() instead of openat()
virtiofsd: Add lo_inode_fd() helper
virtiofsd: Let lo_fd() return a TempFd
virtiofsd: Let lo_inode_open() return a TempFd
virtiofsd: Add lo_inode.fhandle
virtiofsd: Add inodes_by_handle hash table
virtiofsd: Optionally fill lo_inode.fhandle
virtiofsd: Add lazy lo_do_find()
tools/virtiofsd/helper.c | 3 +
tools/virtiofsd/passthrough_ll.c | 836 +++++++++++++++++++++-----
tools/virtiofsd/passthrough_seccomp.c | 2 +
3 files changed, 694 insertions(+), 147 deletions(-)
--
2.31.1
- [PATCH v2 0/9] virtiofsd: Allow using file handles instead of O_PATH FDs,
Max Reitz <=
- [PATCH v2 1/9] virtiofsd: Add TempFd structure, Max Reitz, 2021/06/09
- [PATCH v2 2/9] virtiofsd: Use lo_inode_open() instead of openat(), Max Reitz, 2021/06/09
- [PATCH v2 3/9] virtiofsd: Add lo_inode_fd() helper, Max Reitz, 2021/06/09
- [PATCH v2 4/9] virtiofsd: Let lo_fd() return a TempFd, Max Reitz, 2021/06/09
- [PATCH v2 5/9] virtiofsd: Let lo_inode_open() return a TempFd, Max Reitz, 2021/06/09
- [PATCH v2 7/9] virtiofsd: Add inodes_by_handle hash table, Max Reitz, 2021/06/09