[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions |
Date: |
Wed, 9 Jun 2021 20:49:54 +0200 |
In case we need to use QAPI types but no QAPI command / QAPI event
actually use them, the generated qmp_marshal_output() function will
trigger the compiler 'unused-function' warnings.
To prevent that, emit these functions inlined: the compiler will
ignore such unused functions.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
RFC: No clue about QAPI...
Tested with GCC. If the compiler is picky we could use the 'unused'
function attribute.
---
scripts/qapi/commands.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py
index 0e13d510547..bbed776a909 100644
--- a/scripts/qapi/commands.py
+++ b/scripts/qapi/commands.py
@@ -91,8 +91,8 @@ def gen_call(name: str,
def gen_marshal_output(ret_type: QAPISchemaType) -> str:
return mcgen('''
-static void qmp_marshal_output_%(c_name)s(%(c_type)s ret_in,
- QObject **ret_out, Error **errp)
+static inline void qmp_marshal_output_%(c_name)s(%(c_type)s ret_in,
+ QObject **ret_out, Error **errp)
{
Visitor *v;
--
2.31.1
- [PATCH v2 0/2] tpm: Return QMP error when TPM is disabled in build, Philippe Mathieu-Daudé, 2021/06/09
- [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions,
Philippe Mathieu-Daudé <=
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Eric Blake, 2021/06/09
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Markus Armbruster, 2021/06/10
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Philippe Mathieu-Daudé, 2021/06/10
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Markus Armbruster, 2021/06/10
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Philippe Mathieu-Daudé, 2021/06/10
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Markus Armbruster, 2021/06/11
- Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions, Stefan Berger, 2021/06/11
[PATCH v2 2/2] tpm: Return QMP error when TPM is disabled in build, Philippe Mathieu-Daudé, 2021/06/09