Re: [PATCH 55/55] target/arm: Make VMOV scalar <-> gpreg beatwise for MVE

[Richard Henderson]

On 6/7/21 9:58 AM, Peter Maydell wrote:
> +    if (dc_isar_feature(aa32_mve, s)) {
> +        TCGv_i32 eci;
> +
> +        mve_update_eci(s);
> +        eci = tcg_const_i32(s->eci << 4);
> +        store_cpu_field(eci, condexec_bits);
> +    }

I think it would be handy to package this up into an mve_update_and_store_eci 
function.  There are 3 copies, including the previous in VPST.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~