[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/11] target/i386/monitor: Return QMP error when SEV is disa
From: |
Connor Kuehl |
Subject: |
Re: [PATCH 03/11] target/i386/monitor: Return QMP error when SEV is disabled in build |
Date: |
Thu, 10 Jun 2021 09:52:13 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
> If the management layer tries to inject a secret, it gets an empty
> response in case the binary built without SEV:
>
> { "execute": "sev-inject-launch-secret",
> "arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa":
> 4294959104 }
> }
> {
> "return": {
> }
> }
>
> Make it clearer by returning an error, mentioning the feature is
> disabled:
>
> { "execute": "sev-inject-launch-secret",
> "arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa":
> 4294959104 }
> }
> {
> "error": {
> "class": "GenericError",
> "desc": "this feature or command is not currently supported"
> }
> }
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
- [PATCH 00/11] target/i386/sev: Housekeeping helping using SEV-disabled binaries, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 03/11] target/i386/monitor: Return QMP error when SEV is disabled in build, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 04/11] target/i386/cpu: Add missing 'qapi/error.h' header, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 05/11] target/i386/sev_i386.h: Remove unused headers, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 06/11] target/i386/sev: Remove sev_get_me_mask(), Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 07/11] target/i386/sev: Mark unreachable code with g_assert_not_reached(), Philippe Mathieu-Daudé, 2021/06/10