Re: [PATCH 49/55] target/arm: Implement MVE VQDMULL (vector)

[Richard Henderson]

On 6/10/21 12:08 PM, Peter Maydell wrote:
> On Wed, 9 Jun 2021 at 21:20, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > On 6/7/21 9:58 AM, Peter Maydell wrote:
> > > +++ b/target/arm/mve.decode
> > > @@ -39,6 +39,8 @@
> > >    @1op_nosz .... .... .... .... .... .... .... .... &1op qd=%qd qm=%qm size=0
> > >    @2op .... .... .. size:2 .... .... .... .... .... &2op qd=%qd qm=%qm qn=%qn
> > >    @2op_nosz .... .... .... .... .... .... .... .... &2op qd=%qd qm=%qm qn=%qn 
> > > size=0
> > > +@2op_sz28 .... .... .... .... .... .... .... .... &2op qd=%qd qm=%qm qn=%qn \
> > > +     size=%size_28
> >
> > Move this back to VQDMULL[BT]_scalar, I think.
>
> Why? VQDMULL[BT]_scalar uses an entirely different format
> (as a scalar it uses the &2scalar arg struct with an rm field
> for the gp register).

Oops, mis-read the @2op vs @2scalar.  Sorry.

r~