[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] migration: Add missing dependency on GNUTLS

From: Stefan Weil
Subject: Re: [RFC PATCH] migration: Add missing dependency on GNUTLS
Date: Mon, 14 Jun 2021 10:44:25 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

Am 14.06.21 um 07:26 schrieb Philippe Mathieu-Daudé:

Commit 7de2e856533 made migration/qemu-file-channel.c include
"io/channel-tls.h" but forgot to add the new GNUTLS dependency
on Meson, leading to build failure on OSX:

   [2/35] Compiling C object libmigration.fa.p/migration_qemu-file-channel.c.o
   FAILED: libmigration.fa.p/migration_qemu-file-channel.c.o
   cc -Ilibmigration.fa.p -I. -I.. -Iqapi [ ... ] -o 
libmigration.fa.p/migration_qemu-file-channel.c.o -c 
   In file included from ../migration/qemu-file-channel.c:29:
   In file included from include/io/channel-tls.h:26:
   In file included from include/crypto/tlssession.h:24:
   include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not 
   #include <gnutls/gnutls.h>
   1 error generated.

Reported-by: Stefan Weil <sw@weilnetz.de>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/407
Fixes: 7de2e856533 ("yank: Unregister function when using TLS migration")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
RFC: Not tested on OSX. Stefan, do you know why this isn't covered
      on Cirrus-CI?  https://cirrus-ci.com/build/4876003651616768

Cirrus-CI does not install gnutls. That's easy to fix by adding it to the list of installed packages.

And the patch does not fix the issue. I already had tried that and similar changes in migration/meson.build.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]