Re: [PATCH] Test comment for git-publish

[no-reply]

Patchew URL: 
20210611162033.437690-1-mcascell@redhat.com/">https://patchew.org/QEMU/20210611162033.437690-1-mcascell@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210611162033.437690-1-mcascell@redhat.com
Subject: [PATCH] Test comment for git-publish

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
65950dc Test comment for git-publish

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#21: FILE: hw/rdma/vmw/pvrdma_main.c:430:
+            pvrdma_exec_cmd(dev); // this is a test comment

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 8 lines checked

Commit 65950dcea24f (Test comment for git-publish) has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210611162033.437690-1-mcascell@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210611162033.437690-1-mcascell@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com