qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 6/8] include/qemu/lockable: Use _Generic instead of QEMU_G


From: Alex Bennée
Subject: Re: [PATCH v2 6/8] include/qemu/lockable: Use _Generic instead of QEMU_GENERIC
Date: Tue, 15 Jun 2021 12:25:50 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Richard Henderson <richard.henderson@linaro.org> writes:

> This is both more and less complicated than our expansion
> using __builtin_choose_expr and __builtin_types_compatible_p.
>
> The expansion through QEMU_MAKE_LOCKABLE_ doesn't work because
> we're not emumerating all of the types within the same _Generic,
> which results in errors about unhandled cases.  We must also
> handle void* explicitly, so that the NULL constant can be used.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

and I checked that sync-profile was still working so:

Tested-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]