Re: [PATCH 10/11] target/i386/monitor: Move SEV specific commands to sev.c

[Philippe Mathieu-Daudé]

On 6/10/21 5:19 PM, Connor Kuehl wrote:
> On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
>> Having the HMP/QMP commands defined in monitor.c makes the stubs
>> rather complicated when SEV is not built in. To simplify, move the
>> SEV functions to sev.c, and remove a layer of stubs.
>>
>> Also make it clearer when SEV is not built in, so developers don't
>> try to enable it when it is not enablable:
>>
>>  - before:
>>
>>   (qemu) info sev
>>   SEV is not enabled
>>
>> - after:
>>
>>   (qemu) info sev
>>   SEV is not available in this QEMU
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  target/i386/monitor.c         | 96 ----------------------------------
>>  target/i386/sev-sysemu-stub.c | 29 +++++++----
>>  target/i386/sev.c             | 97 +++++++++++++++++++++++++++++++++++
> 
> Hi Philippe,
> 
> I agree that the split from monitor.c makes it easier to follow. Instead
> of putting the QMP entry points in sev-sysemu-stub. and sev.c, what do
> you think of placing them in sev-qmp-stub.c and sev-qmp.c, respectively?
> 
> I find that appealing from a code organization/module boundary
> perspective.

I tried but this makes the code more complex since sev-qmp.c calls
functions defined in sev.c, we have to keep them declared in a local
header (sev_i386.h). So for v2 I choose to keep the same organization
but exploded the patch for easier review.