Re: [PATCH v3 1/2] hw/nvme: fix endianess conversion and add controller list

[Klaus Jensen]

On Jun 14 21:59, Gollu Appalanaidu wrote:
> Add the controller identifiers list CNS 0x13, available list of ctrls
> in NVM Subsystem that may or may not be attached to namespaces.
>
> In Identify Ctrl List of the CNS 0x12 and 0x13 no endian conversion
> for the nsid field.
>
> These two CNS values shows affect when there exists a Subsystem.
> Added condition if there is no Subsystem return invalid field in
> command.
>
> Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>
> -v3:
> Added condition if there is no Subsystem return invalid field in
> command
>
> -v2:
> Fix the review comments from Klaus and squashed 2nd commit into
> 1st commit
> ---
> hw/nvme/ctrl.c       | 26 ++++++++++++++++++--------
> hw/nvme/trace-events |  2 +-
> include/block/nvme.h |  1 +
> 3 files changed, 20 insertions(+), 9 deletions(-)

Series LGTM.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>

signature.asc
Description: PGP signature