Re: [PULL 00/34] NBD patches for 2021-06-15

[Peter Maydell]

On Tue, 15 Jun 2021 at 21:50, Eric Blake <eblake@redhat.com> wrote:
>
> The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2:
>
>   Merge remote-tracking branch 
> 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging 
> (2021-06-14 15:59:13 +0100)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2021-06-15
>
> for you to fetch changes up to 788b68b57dea4ddd0038f73b96c147eb406c386d:
>
>   block/nbd: safer transition to receiving request (2021-06-15 15:42:33 -0500)
>
> ----------------------------------------------------------------
> nbd patches for 2021-06-15
>
> - bug fixes in coroutine aio context handling
> - rework NBD client connection logic to perform more work in coroutine
> rather than blocking main loop

Fails to compile, all hosts:

../../nbd/client-connection.c: In function ‘nbd_co_establish_connection’:
../../nbd/client-connection.c:352:16: error: ‘ioc’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
  352 |             if (ioc) {
      |                ^


clang is more specific:


../../nbd/client-connection.c:298:21: error: variable 'ioc' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
                if (conn->do_negotiation) {
                    ^~~~~~~~~~~~~~~~~~~~
../../nbd/client-connection.c:302:21: note: uninitialized use occurs here
                if (ioc) {
                    ^~~
../../nbd/client-connection.c:298:17: note: remove the 'if' if its
condition is always true
                if (conn->do_negotiation) {
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
../../nbd/client-connection.c:281:20: note: initialize the variable
'ioc' to silence this warning
    QIOChannel *ioc;
                   ^
                    = NULL
1 error generated.


thanks
-- PMM