Re: [PULL 0/7] Audio 20210617 patches

[no-reply]

Patchew URL: 
20210617124107.2386073-1-kraxel@redhat.com/">https://patchew.org/QEMU/20210617124107.2386073-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210617124107.2386073-1-kraxel@redhat.com
Subject: [PULL 0/7] Audio 20210617 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210617121628.20116-1-peter.maydell@linaro.org -> 
patchew/20210617121628.20116-1-peter.maydell@linaro.org
 * [new tag]         patchew/20210617124107.2386073-1-kraxel@redhat.com -> 
patchew/20210617124107.2386073-1-kraxel@redhat.com
Switched to a new branch 'test'
a6c9846 coreaudio: Fix output stream format settings
32f3f1e audio: Fix format specifications of debug logs
b51279d hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range
e864a29 jackaudio: avoid that the client name contains the word (NULL)
c4a86a7 audio: move code to audio/audio.c
2800db0 paaudio: remove unused stream flags
0b3fd3c alsaaudio: remove #ifdef DEBUG to avoid bit rot

=== OUTPUT BEGIN ===
1/7 Checking commit 0b3fd3ca5f98 (alsaaudio: remove #ifdef DEBUG to avoid bit 
rot)
2/7 Checking commit 2800db079dd3 (paaudio: remove unused stream flags)
3/7 Checking commit c4a86a755701 (audio: move code to audio/audio.c)
4/7 Checking commit e864a29cb0c2 (jackaudio: avoid that the client name 
contains the word (NULL))
5/7 Checking commit b51279d277e6 (hw/audio/sb16: Avoid assertion by restricting 
I/O sampling rate range)
6/7 Checking commit 32f3f1e7b9c4 (audio: Fix format specifications of debug 
logs)
ERROR: space prohibited between function name and open parenthesis '('
#25: FILE: audio/audio.c:708:
+        dolog ("%s is full %zu\n", sw->name, live);

ERROR: space prohibited between function name and open parenthesis '('
#43: FILE: audio/audio.c:1025:
+    dolog ("%s: get_free live %zu dead %zu ret %" PRId64 "\n",

total: 2 errors, 0 warnings, 24 lines checked

Patch 6/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/7 Checking commit a6c98463e79b (coreaudio: Fix output stream format settings)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210617124107.2386073-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210617124107.2386073-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com