Re: [PATCH] hw/nvme: fix pin-based interrupt behavior (again)

[Klaus Jensen]

On Jun 17 07:50, Keith Busch wrote:
> On Thu, Jun 17, 2021 at 12:08:20PM +0200, Klaus Jensen wrote:
> >      if (cq->tail != cq->head) {
> > +        if (!pending) {
> > +            n->cq_pending++;
> > +        }
>
> You should check cq->irq_enabled before incrementing cq_pending. You
> don't want to leave the irq asserted when polled queues have outsanding
> CQEs.

Good catch. Thanks!