[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 43/99] target/arm: move a15 cpu model away from the TCG-o
From: |
Claudio Fontana |
Subject: |
Re: [PATCH v16 43/99] target/arm: move a15 cpu model away from the TCG-only models |
Date: |
Thu, 17 Jun 2021 22:35:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 6/17/21 8:01 PM, Alex Bennée wrote:
>
> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> On 6/4/21 8:52 AM, Alex Bennée wrote:
>>> From: Claudio Fontana<cfontana@suse.de>
>>> Cortex-A15 is the only ARM cpu class we need in KVM too.
>>> We will be able to move it to tcg/ once the board code and
>>> configurations
>>> are fixed.
>>> Signed-off-by: Claudio Fontana<cfontana@suse.de>
>>> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>>> ---
>>> target/arm/cpu32.h | 4 +++
>>> target/arm/cpu32.c | 73 ++++++++++++++++++++++++++++++++++++++++++++
>>> target/arm/cpu_tcg.c | 67 ----------------------------------------
>>> 3 files changed, 77 insertions(+), 67 deletions(-)
>>
>> I don't follow this one. Why would kvm, which is 64-bit only, require
>> a 32-bit only cpu?
>>
>> I guess I can accept that our board configurations are old and
>> fragile, and I realize there are already 99 bottles of beer on^W^W^W^W
>> patches here, but what needs to happen to fix this properly?
>
> I'll drop this and fix whatever we need to. 32 bit ARM KVM is listed in
> removed-features so I think we are good.
Problem is, if I recall correctly, that the virt board currently requires an
a15 to exist.
>
>>
>> I guess I can give it an
>> Acked-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> if it helps us move forward.
>>
>>
>> r~
>
>
- [PATCH v16 32/99] target/arm: move cpsr_read, cpsr_write to cpu_common, (continued)
- [PATCH v16 32/99] target/arm: move cpsr_read, cpsr_write to cpu_common, Alex Bennée, 2021/06/04
- [PATCH v16 26/99] target/arm: move physical address translation to cpu-mmu, Alex Bennée, 2021/06/04
- [PATCH v16 64/99] tests: do not run test-hmp on all machines for ARM KVM-only, Alex Bennée, 2021/06/04
- [PATCH v16 28/99] target/arm: split cpregs from tcg/helper.c, Alex Bennée, 2021/06/04
- [PATCH v16 58/99] target/arm: move kvm-const.h, kvm.c, kvm64.c, kvm_arm.h to kvm/, Alex Bennée, 2021/06/04
- [PATCH v16 39/99] target/arm: move arm_cpu_list to common_cpu, Alex Bennée, 2021/06/04
- [PATCH v16 43/99] target/arm: move a15 cpu model away from the TCG-only models, Alex Bennée, 2021/06/04
- [PATCH v16 85/99] target/arm: cpu-pauth: new module for ARMv8.3 Pointer Authentication, Alex Bennée, 2021/06/04
- [PATCH v16 84/99] target/arm: cpu-common: wrap a64-only check with is_a64, Alex Bennée, 2021/06/04
- [PATCH v16 60/99] target/arm: cleanup cpu includes, Alex Bennée, 2021/06/04
- [PATCH v16 71/99] target/arm: cpu-sve: new module, Alex Bennée, 2021/06/04
- [PATCH v16 69/99] target/arm: add tcg cpu accel class, Alex Bennée, 2021/06/04