Re: [PATCH v5 9/9] qapi: make 'if' condition strings simple identifiers

[Markus Armbruster]

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Change the 'if' condition strings to be C-agnostic and be simple
> identifiers.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Tested-by: John Snow <jsnow@redhat.com>

[...]

> diff --git a/tests/qapi-schema/doc-good.txt b/tests/qapi-schema/doc-good.txt
> index 726727af74..27b7ce8799 100644
> --- a/tests/qapi-schema/doc-good.txt
> +++ b/tests/qapi-schema/doc-good.txt
> @@ -43,7 +43,7 @@ Example:
>  Values
>  ~~~~~~
>  
> -"one" (**If: **"defined(IFONE)")
> +"one" (**If: **"IFONE")

Preexisting: the text generated for conditionals is crap.  Your patch
doesn't make it any worse.

>     The _one_ {and only}
>  
>  "two"
> @@ -62,7 +62,7 @@ Features
>  If
>  ~~
>  
> -"defined(IFCOND)"
> +"IFCOND"
>  
>  
>  "Base" (Object)
> @@ -87,7 +87,7 @@ Another paragraph (but no "var": line)
>  Members
>  ~~~~~~~
>  
> -"var1": "string" (**If: **"defined(IFSTR)")
> +"var1": "string" (**If: **"IFSTR")
>     Not documented
>  
>  

[...]