Re: [PATCH 5/9] target/mips: Restrict some system specific declarations to sysemu

[Richard Henderson]

On 6/17/21 10:43 AM, Philippe Mathieu-Daudé wrote:
> Commit 043715d1e0f ("target/mips: Update ITU to utilize SAARI
> and SAAR CP0 registers") declared itc_reconfigure() in public
> namespace, while it is restricted to system emulation.
>
> Similarly commit 5679479b9a1 ("target/mips: Move CP0 helpers
> to sysemu/cp0.c") restricted cpu_mips_soft_irq() definition to
> system emulation, but forgot to restrict its declaration.
>
> Commit a2b0a27d33e ("target/mips: Move TCG source files under
> tcg/ sub directory") restricted mips_cpu_do_unaligned_access()
> to system emulation but forgot to guard the declaration.

FWIW, I think the unaligned_access tcg_ops hook should be available for user-only as well, 
like for tlb_fill.  That it is sysemu only at the moment is a bug that affects user-only 
atomic access.

Anyway,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

> To avoid polluting user-mode emulation with these declarations,
> restrict them to sysemu. Also restrict the sysemu ITU/ITC/IRQ
> fields from CPUMIPSState.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/cpu.h              | 10 +++++++---
>   target/mips/tcg/tcg-internal.h |  6 +++---
>   2 files changed, 10 insertions(+), 6 deletions(-)