[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/9] target/mips: Restrict some system specific declarations

From: Richard Henderson
Subject: Re: [PATCH 5/9] target/mips: Restrict some system specific declarations to sysemu
Date: Fri, 18 Jun 2021 15:38:33 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/17/21 10:43 AM, Philippe Mathieu-Daudé wrote:
Commit 043715d1e0f ("target/mips: Update ITU to utilize SAARI
and SAAR CP0 registers") declared itc_reconfigure() in public
namespace, while it is restricted to system emulation.

Similarly commit 5679479b9a1 ("target/mips: Move CP0 helpers
to sysemu/cp0.c") restricted cpu_mips_soft_irq() definition to
system emulation, but forgot to restrict its declaration.

Commit a2b0a27d33e ("target/mips: Move TCG source files under
tcg/ sub directory") restricted mips_cpu_do_unaligned_access()
to system emulation but forgot to guard the declaration.

FWIW, I think the unaligned_access tcg_ops hook should be available for user-only as well, like for tlb_fill. That it is sysemu only at the moment is a bug that affects user-only atomic access.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


To avoid polluting user-mode emulation with these declarations,
restrict them to sysemu. Also restrict the sysemu ITU/ITC/IRQ
fields from CPUMIPSState.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
  target/mips/cpu.h              | 10 +++++++---
  target/mips/tcg/tcg-internal.h |  6 +++---
  2 files changed, 10 insertions(+), 6 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]