[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl
From: |
Steven Price |
Subject: |
Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl |
Date: |
Mon, 21 Jun 2021 09:18:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 18/06/2021 15:52, Catalin Marinas wrote:
> On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote:
>> +When this capability is enabled all memory in (non-device) memslots must not
>> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will
>> result
>> +in an -EINVAL return.
>
> "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as
> that's a kernel internal and not something the VMM needs to be aware of.
> Just say something like "memslots must be mapped as shareable
> (MAP_SHARED)".
I think I meant "must not use" - and indeed memslots must *not* be
mapped as shareable. I'll update to this wording:
When this capability is enabled all memory in memslots must be mapped as
not-shareable (no MAP_SHARED), attempts to create a memslot with MAP_SHARED
will result in an -EINVAL return.
> Otherwise:
>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>
Thanks,
Steve
- [PATCH v16 2/7] arm64: mte: Sync tags for pages where PTE is untagged, (continued)
- [PATCH v16 2/7] arm64: mte: Sync tags for pages where PTE is untagged, Steven Price, 2021/06/18
- [PATCH v16 3/7] KVM: arm64: Introduce MTE VM feature, Steven Price, 2021/06/18
- [PATCH v16 4/7] KVM: arm64: Save/restore MTE registers, Steven Price, 2021/06/18
- [PATCH v16 5/7] KVM: arm64: Expose KVM_ARM_CAP_MTE, Steven Price, 2021/06/18
- [PATCH v16 6/7] KVM: arm64: ioctl to fetch/store tags in a guest, Steven Price, 2021/06/18
- [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl, Steven Price, 2021/06/18