[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 13/16] qemu-iotests: insert valgrind command line as wrapper f
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v6 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary |
Date: |
Mon, 21 Jun 2021 12:33:34 +0200 |
If -gdb and -valgrind are both defined, return an error.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 85d8c0abbb..7aa6707032 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -591,7 +591,11 @@ class VM(qtest.QEMUQtestMachine):
def __init__(self, path_suffix=''):
name = "qemu%s-%d" % (path_suffix, os.getpid())
timer = 15.0 if not (qemu_gdb or qemu_valgrind) else None
- super().__init__(qemu_prog, qemu_opts, wrapper=qemu_gdb,
+ if qemu_gdb and qemu_valgrind:
+ sys.stderr.write('Either use gdb or valgrind, not together\n')
+ sys.exit(1)
+ wrapper = qemu_gdb if qemu_gdb else qemu_valgrind
+ super().__init__(qemu_prog, qemu_opts, wrapper=wrapper,
name=name,
base_temp_dir=test_dir,
socket_scm_helper=socket_scm_helper,
--
2.31.1
- [PATCH v6 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine, (continued)
- [PATCH v6 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 02/16] python: Reduce strictness of pylint's duplicate-code check, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 05/16] qemu-iotests: add option to attach gdbserver, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 06/16] qemu-iotests: delay QMP socket timers, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 08/16] qemu-iotests: add gdbserver option to script tests too, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 11/16] qemu-iotests: extend QMP socket timeout when using valgrind, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary,
Emanuele Giuseppe Esposito <=
- [PATCH v6 12/16] qemu-iotests: allow valgrind to read/delete the generated log file, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 15/16] qemu-iotests: add option to show qemu binary logs on stdout, Emanuele Giuseppe Esposito, 2021/06/21
- [PATCH v6 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/06/21