Re: [PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN

[Richard Henderson]

On 6/21/21 1:01 PM, Philippe Mathieu-Daudé wrote:
> On 6/20/21 11:32 PM, Richard Henderson wrote:
> > The only semantic of DISAS_TB_JUMP is that we've done goto_tb,
> > which is the same as DISAS_NORETURN -- we've exited the tb.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/cris/translate.c | 7 +++----
> >   1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/target/cris/translate.c b/target/cris/translate.c
> > index bed7a7ed10..2ff4319dd1 100644
> > --- a/target/cris/translate.c
> > +++ b/target/cris/translate.c
> > @@ -55,7 +55,6 @@
> >   /* is_jmp field values */
> >   #define DISAS_JUMP    DISAS_TARGET_0 /* only pc was modified dynamically */
> >   #define DISAS_UPDATE  DISAS_TARGET_1 /* cpu state was modified dynamically */
> > -#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */
> >   #define DISAS_SWI     DISAS_TARGET_3
>
> Can we #define DISAS_SWI DISAS_TARGET_2 in the same commit?

No point.  It goes away in patch 4.


r~