qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/11] block: add max_hw_transfer to BlockLimits


From: Max Reitz
Subject: Re: [PATCH 05/11] block: add max_hw_transfer to BlockLimits
Date: Fri, 25 Jun 2021 09:58:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 24.06.21 20:04, Paolo Bonzini wrote:
For block host devices, I/O can happen through either the kernel file
descriptor I/O system calls (preadv/pwritev, io_submit, io_uring)
or the SCSI passthrough ioctl SG_IO.

In the latter case, the size of each transfer can be limited by the
HBA, while for file descriptor I/O the kernel is able to split and
merge I/O in smaller pieces as needed.  Applying the HBA limits to
file descriptor I/O results in more system calls and suboptimal
performance, so this patch splits the max_transfer limit in two:
max_transfer remains valid and is used in general, while max_hw_transfer
is limited to the maximum hardware size.  max_hw_transfer can then be
included by the scsi-generic driver in the block limits page, to ensure
that the stricter hardware limit is used.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  block/block-backend.c          | 13 +++++++++++++
  block/file-posix.c             |  2 +-
  block/io.c                     |  2 ++
  hw/scsi/scsi-generic.c         |  2 +-
  include/block/block_int.h      |  7 +++++++
  include/sysemu/block-backend.h |  1 +
  6 files changed, 25 insertions(+), 2 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]