[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/7] scripts/checkpatch: roll diff tweaking into checkpatch itself
From: |
Alex Bennée |
Subject: |
[PULL 3/7] scripts/checkpatch: roll diff tweaking into checkpatch itself |
Date: |
Fri, 25 Jun 2021 10:13:51 +0100 |
Rather than relying on external tweaks lets just do it inside
checkpatch's direct commitish handling which is QEMU specific code
anyway.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210623102749.25686-4-alex.bennee@linaro.org>
diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
index 7e685c6a65..c5fa4fce26 100644
--- a/.gitlab-ci.d/static_checks.yml
+++ b/.gitlab-ci.d/static_checks.yml
@@ -4,9 +4,6 @@ check-patch:
needs:
job: amd64-centos8-container
script:
- - git config --local diff.renamelimit 0
- - git config --local diff.renames True
- - git config --local diff.algorithm histogram
- .gitlab-ci.d/check-patch.py
variables:
GIT_DEPTH: 1000
diff --git a/.patchew.yml b/.patchew.yml
index 2638b7f564..1b78262ce5 100644
--- a/.patchew.yml
+++ b/.patchew.yml
@@ -138,9 +138,6 @@ testing:
script: |
#!/bin/bash
git rev-parse base > /dev/null || exit 0
- git config --local diff.renamelimit 0
- git config --local diff.renames True
- git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
docker-mingw@fedora:
enabled: true
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bbcd25ae05..cb8eff233e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -399,7 +399,12 @@ if ($chk_branch) {
my $num_patches = @patches;
for my $hash (@patches) {
my $FILE;
- open($FILE, '-|', "git", "show", "--patch-with-stat", $hash) ||
+ open($FILE, '-|', "git",
+ "-c", "diff.renamelimit=0",
+ "-c", "diff.renames=True",
+ "-c", "diff.algorithm=histogram",
+ "show",
+ "--patch-with-stat", $hash) ||
die "$P: git show $hash - $!\n";
while (<$FILE>) {
chomp;
--
2.20.1
- [PULL 0/7] misc fixes (docs, plugins, tests), Alex Bennée, 2021/06/25
- [PULL 1/7] tests/acceptance: tweak the tcg/kvm tests for virt, Alex Bennée, 2021/06/25
- [PULL 2/7] docs/devel: Add a single top-level header to MTTCG's doc, Alex Bennée, 2021/06/25
- [PULL 3/7] scripts/checkpatch: roll diff tweaking into checkpatch itself,
Alex Bennée <=
- [PULL 4/7] GitLab: Add "Bug" issue reporting template, Alex Bennée, 2021/06/25
- [PULL 5/7] GitLab: Add "Feature Request" issue template., Alex Bennée, 2021/06/25
- [PULL 7/7] plugins/api: expose symbol lookup to plugins, Alex Bennée, 2021/06/25
- [PULL 6/7] tests/tcg: skip the signals test for hppa/s390x for now, Alex Bennée, 2021/06/25
- Re: [PULL 0/7] misc fixes (docs, plugins, tests), Peter Maydell, 2021/06/25
- Re: [PULL 0/7] misc fixes (docs, plugins, tests), Peter Maydell, 2021/06/25
- Re: [PULL 0/7] misc fixes (docs, plugins, tests), Peter Maydell, 2021/06/28