[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] python: Remove global pylint suppressions
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH 02/11] python: Remove global pylint suppressions |
Date: |
Fri, 25 Jun 2021 15:18:31 -0300 |
On Fri, Jun 25, 2021 at 12:46 PM John Snow <jsnow@redhat.com> wrote:
>
> These suppressions only apply to a small handful of places. Instead of
> disabling them globally, disable them just in the cases where we
> need. The design of the machine class grew quite organically with tons
> of constructor and class instance variables -- there's little chance of
> meaningfully refactoring it in the near term, so just suppress the
> warnings for that class.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine/machine.py | 3 +++
> python/qemu/machine/qtest.py | 2 ++
> python/setup.cfg | 4 +---
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>