Re: [PATCH 08/11] python: add 'make check-venv' invocation

[John Snow]

On 6/25/21 3:01 PM, Willian Rampazzo wrote:
> On Fri, Jun 25, 2021 at 3:38 PM John Snow <jsnow@redhat.com> wrote:
> > On 6/25/21 2:36 PM, Willian Rampazzo wrote:
> > > Maybe, it may confuse people using `make check-venv` under `tests`.
> > > Anyway, I'm not opposed to it.
> > >
> > > Reviewed-by: Willian Rampazzo<willianr@redhat.com>
> >
> > I have to admit there's much about Python packaging that is confusing :)
>
> Oh, the comment was not so related to packaging, but to QEMU itself.
>
> > Can you elaborate on your point for me, though?
>
> Under the `tests` folder, `make check-venv` creates the Python venv
> for the tests. It does not run the tests. The `make check-venv` under
> the `pyhton` folder proposed here will actually run the tests in the
> venv. My comment was related to people already used to the behavior of
> `make` under the `tests` folder.
>
> I don't think it is this patch fault and I think this makes more sense
> than what we currently have under the `tests` folder. Maybe it is just
> a matter of organizing the `tests` folder `make` command.

OH, I see what you're saying. It's the ambiguity between:

1. make [the] 'check' venv
2. make check, [with the] venv

I chose one semantic and tests/ chose another. Valid concern.

I suppose if someone does get it mixed up it won't hurt too much though, 
they'll certainly notice pretty quickly that 'check-venv' runs tests.

Cleber, my #1 co-maintainer, do you have any preferences here?

--js