[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 24/29] target/i386: Improve bswap translation
From: |
Richard Henderson |
Subject: |
[PATCH v3 24/29] target/i386: Improve bswap translation |
Date: |
Fri, 25 Jun 2021 23:36:26 -0700 |
Use a break instead of an ifdefed else.
There's no need to move the values through s->T0.
Remove TCG_BSWAP_IZ and the preceding zero-extension.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/i386/tcg/translate.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index e8a9dcd21a..b21873ed23 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -7195,17 +7195,11 @@ static target_ulong disas_insn(DisasContext *s,
CPUState *cpu)
reg = (b & 7) | REX_B(s);
#ifdef TARGET_X86_64
if (dflag == MO_64) {
- gen_op_mov_v_reg(s, MO_64, s->T0, reg);
- tcg_gen_bswap64_i64(s->T0, s->T0);
- gen_op_mov_reg_v(s, MO_64, reg, s->T0);
- } else
-#endif
- {
- gen_op_mov_v_reg(s, MO_32, s->T0, reg);
- tcg_gen_ext32u_tl(s->T0, s->T0);
- tcg_gen_bswap32_tl(s->T0, s->T0, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- gen_op_mov_reg_v(s, MO_32, reg, s->T0);
+ tcg_gen_bswap64_i64(cpu_regs[reg], cpu_regs[reg]);
+ break;
}
+#endif
+ tcg_gen_bswap32_tl(cpu_regs[reg], cpu_regs[reg], TCG_BSWAP_OZ);
break;
case 0xd6: /* salc */
if (CODE64(s))
--
2.25.1
- Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions, (continued)
- [PATCH v3 16/29] tcg/tci: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 15/29] tcg/mips: Support bswap flags in tcg_out_bswap32, Richard Henderson, 2021/06/26
- [PATCH v3 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/26
- [PATCH v3 25/29] target/sh4: Improve swap.b translation, Richard Henderson, 2021/06/26
- [PATCH v3 22/29] target/arm: Improve vector REV, Richard Henderson, 2021/06/26
- [PATCH v3 14/29] tcg/mips: Support bswap flags in tcg_out_bswap16, Richard Henderson, 2021/06/26
- [PATCH v3 17/29] tcg: Handle new bswap flags during optimize, Richard Henderson, 2021/06/26
- [PATCH v3 24/29] target/i386: Improve bswap translation,
Richard Henderson <=
- [PATCH v3 19/29] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*, Richard Henderson, 2021/06/26
- [PATCH v3 13/29] tcg/s390: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 23/29] target/arm: Improve REVSH, Richard Henderson, 2021/06/26
- [PATCH v3 29/29] tcg/riscv: Remove MO_BSWAP handling, Richard Henderson, 2021/06/26
- [PATCH v3 18/29] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64, Richard Henderson, 2021/06/26
- [PATCH v3 21/29] target/arm: Improve REV32, Richard Henderson, 2021/06/26
- [PATCH v3 26/29] target/mips: Fix gen_mxu_s32ldd_s32lddr, Richard Henderson, 2021/06/26
- [PATCH v3 28/29] tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/26