Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

[Richard Henderson]

On 6/28/21 9:33 AM, Philippe Mathieu-Daudé wrote:
> > I don't mind the ordering, just that there's a reason.
>
> Is that OK if I reword as:
>
> ---
> We want to extract the microMIPS ISA and Code Compaction ASE to
> new compilation units.
>
> We will first extract this code as included source files (.c.inc),
> then make them new compilation units afterward.
>
> The following methods are going to be used externally:
>
>    micromips_translate.c.inc:1778:   gen_ldxs(ctx, rs, rt, rd);
>    micromips_translate.c.inc:1806:   gen_align(ctx, 32, rd, rs, ...
>    micromips_translate.c.inc:2859:   gen_addiupc(ctx, reg, offset, ...
>    mips16e_translate.c.inc:444:      gen_addiupc(ctx, ry, offset, ...
>
> To avoid too much code churn, it is simpler to declare these
> prototypes in "translate.h" now.
> ---

Sure.


r~