[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 6/6] migration/dirtyrate: implement dirty-ring dirtyrate
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v10 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation |
|
Date: |
Mon, 28 Jun 2021 19:05:54 -0400 |
On Mon, Jun 28, 2021 at 12:27:46AM +0800, huangy81@chinatelecom.cn wrote:
> +static void dirtyrate_global_dirty_log_stop(void)
> +{
> + qemu_mutex_lock_iothread();
One thing I missed: maybe we want to sync dirty before stop, so the value will
be more accurate. Perhaps a call to memory_global_dirty_log_sync() here?
> + memory_global_dirty_log_stop(GLOBAL_DIRTY_DIRTY_RATE);
> + qemu_mutex_unlock_iothread();
> +}
--
Peter Xu